flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] TisonKun commented on a change in pull request #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo…
Date Tue, 09 Apr 2019 13:09:47 GMT
TisonKun commented on a change in pull request #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider
to TestingLogicalSlo…
URL: https://github.com/apache/flink/pull/7809#discussion_r273481843
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/TestingLogicalSlotProvider.java
 ##########
 @@ -53,30 +52,31 @@
 /**
  * A testing utility slot provider that simply has a predefined pool of slots.
  */
-public class SimpleSlotProvider implements SlotProvider, SlotOwner {
+public class TestingLogicalSlotProvider implements SlotProvider, SlotOwner {
 
 Review comment:
   There are many `TestingSlotProvider` in fact...Also we can get few info from the name `SimpleSlotProvider`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message