flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)
Date Wed, 10 Apr 2019 12:48:30 GMT
pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain
unconsumed result partitions (on top of #7186)
URL: https://github.com/apache/flink/pull/7938#discussion_r273935915
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
 ##########
 @@ -124,7 +124,7 @@ private void enqueueAvailableReader(final NetworkSequenceViewReader reader)
thro
 		return availableReaders;
 	}
 
-	public void notifyReaderCreated(final NetworkSequenceViewReader reader) {
+	void notifyReaderCreated(final NetworkSequenceViewReader reader) {
 
 Review comment:
   nit: are the changes in this file part of previous commit or a separate hotfix/refactor/clean
up?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message