pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain
unconsumed result partitions (on top of #7186)
URL: https://github.com/apache/flink/pull/7938#discussion_r273935683
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -378,7 +378,10 @@ public void releaseMemory(int toRelease) throws IOException {
}
/**
- * Whether this partition is released, e.g. all subpartitions are consumed or task is cancelled.
+ * Whether this partition is released.
Review comment:
nit: Shouldn't this be a part of previous commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|