flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dawidwys opened a new pull request #8149: [FLINK-12165][table-planner] Added resolution rule that checks all unresolved expressions are resolved
Date Thu, 11 Apr 2019 09:28:44 GMT
dawidwys opened a new pull request #8149: [FLINK-12165][table-planner] Added resolution rule
that checks all unresolved expressions are resolved
URL: https://github.com/apache/flink/pull/8149
 
 
   ## What is the purpose of the change
   
   Adds a rule to `ExpressionResolver` that makes sure all expressions coming out of it are
resolved.
   
   ## Brief change log
   
   - Added `VerifyNoUnresolvedExpressionsRule`
   - Enabled this rule in `ExpressionResolver`
   
   
   ## Verifying this change
   
   - Added tests in `VerifyNoUnresolvedExpressionsRuleTest` for negative cases
   - For positive cases (when all expressions are resolved) all current tests should pass.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message