flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol opened a new pull request #8151: [FLINK-12102][tests] Fix FlinkILoopTest on Java 9
Date Thu, 11 Apr 2019 12:37:13 GMT
zentol opened a new pull request #8151: [FLINK-12102][tests] Fix FlinkILoopTest on Java 9
URL: https://github.com/apache/flink/pull/8151
 
 
   ## What is the purpose of the change
   
   Fixes an issue in the FlinkILoopTest where the test failed on Java 9.
   
   From my understanding, powermock loads classes in a separate classloader during mocking.
However powermock does not account for Java 9 modules (see https://github.com/powermock/powermock/issues/864),
due to which the loading will fail if the class is not available by default on java 9, as
is the case for `javax` classes.
   
   Apparently the `PowerMockIgnore` annotation stops powermock from separately loading the
class, and thus the test can pass.
   
   
   ## Verifying this change
   
   I ran the test successfully on java 9 on a dev branch: https://travis-ci.org/zentol/flink/jobs/518712231
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message