flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …
Date Fri, 12 Apr 2019 04:26:22 GMT
sunjincheng121 commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog,
and other …
URL: https://github.com/apache/flink/pull/8007#issuecomment-482432502
 
 
   Thank for the comments and reply @wuchong @dawidwys  @xuefuz @bowenli86 :-)
   
   I agree that catalog API is different from SQL DDL. But I think it shares big common with
SQL APIs and It would be good if we can keep the catalog API align with SQL, especially for
some very common methods like `listTables`.
   
   In the two approaches I proposed to unify the API, I still like listTables to return tables
and views together. (I agree with the current(7efb860) PR changes about `listTables`).
   
   Regarding moving to the mailing list, If most of the changes in the PR have been agreed,
and there are only a few different opinions, such as: `listTables` not have a consensus, it
is an efficient way to discuss in the PR and reach a consensus. As for the review, I don't
think we need to move the current discussion into the mailing list.
   
   - We have already gone over the PR very carefully. And it comes very close to the merging.
   - I don't think we should bring everything to the dev mailing list but a discussion on
the Jira ticket would be also good(just like the quote from jark's reply).
   
   From the points of my view, the PR looks good to me, after @xuefuz addresses the comments
form @dawidwys.
   
   What do you think?
   
   Best,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message