flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi
Date Fri, 12 Apr 2019 06:33:21 GMT
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations
for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274774904
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
 ##########
 @@ -477,6 +484,18 @@ class TableImpl(
   private def wrap(operation: TableOperation): Table = {
     new TableImpl(tableEnv, operation)
   }
+
+  private[flink] def getOutputFieldReferences: Seq[UnresolvedFieldReferenceExpression] =
{
+    operationTree.asInstanceOf[LogicalNode]
+      .output.map(a => new UnresolvedFieldReferenceExpression(a.name))
+  }
+
+  private[flink] def resolveCalls(fields: Seq[Expression]): Seq[Expression] = {
+    val outputFieldReferences = operationTree.asInstanceOf[LogicalNode]
+      .output.map(a => new UnresolvedFieldReferenceExpression(a.name))
+    val expander = new ColumnsOperationExpander(outputFieldReferences)
 
 Review comment:
   We need to expand columns before `extractFieldReferences`, so that to get the correct field
references.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message