flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation
Date Fri, 12 Apr 2019 15:09:39 GMT
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink]
Support translation from Rank/Deduplicate to StreamTransformation
URL: https://github.com/apache/flink/pull/8109#discussion_r274949277
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecExchange.scala
 ##########
 @@ -32,7 +44,10 @@ class StreamExecExchange(
     relNode: RelNode,
     relDistribution: RelDistribution)
   extends CommonPhysicalExchange(cluster, traitSet, relNode, relDistribution)
-  with StreamPhysicalRel {
+  with StreamPhysicalRel
+  with StreamExecNode[BaseRow] {
+
+  private val DEFAULT_MAX_PARALLELISM = 1 << 7
 
 Review comment:
   The variable's name is confusing, it's not max parallelism of operators, but max number
of key-groups. Maybe it's better to use `StreamGraphGenerator.DEFAULT_LOWER_BOUND_MAX_PARALLELISM`
or `KeyGroupRangeAssignment.DEFAULT_LOWER_BOUND_MAX_PARALLELISM`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message