flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator
Date Sun, 14 Apr 2019 07:52:42 GMT
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling
in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r275144408
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -666,10 +671,11 @@ else if (!props.forceCheckpoint()) {
 	 * Receives a {@link DeclineCheckpoint} message for a pending checkpoint.
 	 *
 	 * @param message Checkpoint decline from the task manager
+	 * @return <code>true</code> if should fail the job
 	 */
-	public void receiveDeclineMessage(DeclineCheckpoint message) {
+	public boolean receiveDeclineMessage(DeclineCheckpoint message) {
 
 Review comment:
   @StefanRRichter You are right. The expected thing you mentioned is our second step, we
will introduce a `CheckpointFailureManager` that will decide how to process failure. Currently,
based on @azagrebin 's suggestion we should refactor the failure handling to prepare for the
second step, the design document is here : https://docs.google.com/document/d/1ce7RtecuTxcVUJlnU44hzcO2Dwq9g4Oyd8_biy94hJc/edit?usp=sharing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message