flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces
Date Mon, 15 Apr 2019 03:42:10 GMT
wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments
to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r275199185

 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlannerConfig.java
 @@ -0,0 +1,29 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.api;
+import org.apache.flink.annotation.PublicEvolving;
+ * The {@link PlannerConfig} holds parameters to configure the behavior of queries.
+ */
+public interface PlannerConfig {
 Review comment:
   What about return T directly instead of wrapping in a `Optional`?
   We can return null or throw exception if the type not matched. It will allow us to write
more fluent code when we are clear what the `PlannerConfig` type is, i.e. `tableConfig.getPlannerConfig().unwrap(DefaultPlannerConfig.class)`.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message