flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type
Date Mon, 15 Apr 2019 09:00:28 GMT
GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn
application type
URL: https://github.com/apache/flink/pull/7978#discussion_r275264424
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##########
 @@ -138,6 +138,8 @@
 	private String zookeeperNamespace;
 
 	private String nodeLabel;
+	/* This field can be override by dynamic property application-type */
 
 Review comment:
   I think the comment here is not needed:
   1. It's a non-javadoc comment. Javadoc comments start with `/**`
   1. The name is self-explanatory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message