flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] twalthr commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions
Date Mon, 15 Apr 2019 11:11:34 GMT
twalthr commented on a change in pull request #8062:  [FLINK-11884][table] Implement expression
resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r275307745
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/logical/LogicalWindow.scala
 ##########
 @@ -30,14 +29,12 @@ import org.apache.flink.table.validate.{ValidationFailure, ValidationResult,
Val
   */
 abstract class LogicalWindow(
     val aliasAttribute: PlannerExpression,
-    val timeAttribute: PlannerExpression)
-  extends Resolvable[LogicalWindow] {
+    val timeAttribute: PlannerExpression) {
 
-  def resolveExpressions(resolver: (PlannerExpression) => PlannerExpression): LogicalWindow
= this
-
-  def validate(tableEnv: TableEnvironment): ValidationResult = aliasAttribute match {
-    case WindowReference(_, _) => ValidationSuccess
-    case _ => ValidationFailure("Window reference for window expected.")
+  def validate(isStreaming: Boolean): Unit = aliasAttribute match {
+    case WindowReference(_, _) =>
 
 Review comment:
   add a comment here, first I thought it is a fall-through

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message