flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator
Date Mon, 15 Apr 2019 12:39:40 GMT
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure
handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r275339590
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -666,10 +671,11 @@ else if (!props.forceCheckpoint()) {
 	 * Receives a {@link DeclineCheckpoint} message for a pending checkpoint.
 	 *
 	 * @param message Checkpoint decline from the task manager
+	 * @return <code>true</code> if should fail the job
 	 */
-	public void receiveDeclineMessage(DeclineCheckpoint message) {
+	public boolean receiveDeclineMessage(DeclineCheckpoint message) {
 
 Review comment:
   Maybe shorten this PR by reverting the behaviour changes, then open a PR that introduces
the manager, then add a third PR redoing the behaviour changes. Like that I also don't need
to imagine how the code is intended to look at some point in the future, but can comment what
is in front of me :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message