flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #7813: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy
Date Tue, 16 Apr 2019 09:17:55 GMT
StefanRRichter commented on a change in pull request #7813: [FLINK-10712] Support to restore
state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7813#discussion_r275704960
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java
 ##########
 @@ -206,13 +228,15 @@ private void restart(long globalModVersionOfFailover) {
 		try {
 			if (transitionState(JobStatus.CREATED, JobStatus.RUNNING)) {
 				// if we have checkpointed state, reload it into the executions
-				//TODO: checkpoint support restore part ExecutionVertex cp
-				/**
 				if (executionGraph.getCheckpointCoordinator() != null) {
+					// we restart the checkpoint scheduler for
+					// i) enable new checkpoint could be triggered without waiting for last checkpoint expired.
+					// ii) ensure the EXACTLY_ONCE semantics if needed.
+					executionGraph.getCheckpointCoordinator().cancelPendingCheckpoints();
+
 					executionGraph.getCheckpointCoordinator().restoreLatestCheckpointedState(
 
 Review comment:
   Yes, that sounds crazy but I guess there was always something more important to do and
it can also be dangerous to make such changes if the existing code works well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message