flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] godfreyhe commented on a change in pull request #8165: [FLINK-12185] [table-planner-blink] Add support for generating optimized logical plan for join on stream
Date Tue, 16 Apr 2019 13:21:11 GMT
godfreyhe commented on a change in pull request #8165: [FLINK-12185] [table-planner-blink]
Add support for generating optimized logical plan for join on stream
URL: https://github.com/apache/flink/pull/8165#discussion_r275792290

 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/rules/physical/stream/StreamExecJoinRule.scala
 @@ -0,0 +1,126 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.plan.rules.physical.stream
+import org.apache.flink.table.api.TableException
+import org.apache.flink.table.calcite.{FlinkContext, FlinkTypeFactory}
+import org.apache.flink.table.plan.`trait`.FlinkRelDistribution
+import org.apache.flink.table.plan.nodes.FlinkConventions
+import org.apache.flink.table.plan.nodes.logical.{FlinkLogicalJoin, FlinkLogicalRel}
+import org.apache.flink.table.plan.nodes.physical.stream.StreamExecJoin
+import org.apache.flink.table.plan.util.WindowJoinUtil
+import org.apache.calcite.plan.RelOptRule.{any, operand}
+import org.apache.calcite.plan.{RelOptRule, RelOptRuleCall, RelTraitSet}
+import org.apache.calcite.rel.RelNode
+import java.util
+import scala.collection.JavaConversions._
+  * Rule that converts [[FlinkLogicalJoin]] without window bounds in join condition
+  * to [[StreamExecJoin]].
+  */
+class StreamExecJoinRule
 Review comment:
   The conclusion of the offline discussion is "add some comments to explain StreamExecJoin,
and keep same name style as flink-planner (DataStreamJoin, DataStreamJoinRule, DataStreamWindowJoin,

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message