flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
Date Wed, 17 Apr 2019 05:49:52 GMT
zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish
between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#issuecomment-483946313
 
 
   After further thinking through this issue, the current created local/remote counter would
be registered into `MetricRegistry` and then notified for `MetricReporter`. If users have
other `MetricReporter` implementations which might rely on these reported local/remote metrics,
it seems better to keep the previous behavior although there are no separate usages of these
metrics in flink framework handlers.
   
   In order not to block the following work for decoupling the `TaskIOMetric` with `NetworkEnvironment`,
I think of another way to work around. We could create the `numBytesInTotal` counter which
seems more general for all the implementations in `TaskIOMetricGroup` instead of separate
`numBytesInLocal` and `numBytesInRemote`. And during creating `SingleInputGate` we could pass
`ProxyMetricGroup` for the input channel to create `numBytesInLocal` and `numBytesInRemote`
separately, because these two metrics are specific with implementations of `LocalInputChannel`
and `RemoteInputChannel`.
   
   During `InputChannel#getNextBuffer`, the `numBytesInTotal` and `numBytesInLocal/Remote`
are both updated internally. The current flink handlers could fetch `numBytesInTotal` directly
via `IOMetrics`, and outside users could still see the meaningful `numBytesInLocal/Remote`
metrics in specific reporter as before. What do you think ? @zentol  @azagrebin 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message