flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
Date Wed, 17 Apr 2019 09:06:18 GMT
zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish
between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#issuecomment-484001811
 
 
   Thanks for replies @azagrebin .
   
   Yes, we should confirm there only exists one local/remote metrics per task. Based on current
implementation, it seems that the `ProxyMetricGroup` would only create on metric based on
metric name even though we call create in all the channels, that means the other calls would
reference with the previous created local/remote metric. So we might not worry about that.
   
   Agree with the point of operating total metrics temporarily in `SingleInputGate` before
introducing `InputGateWithMetrics`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message