flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type
Date Wed, 17 Apr 2019 14:27:09 GMT
GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn
application type
URL: https://github.com/apache/flink/pull/7978#discussion_r276267053
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##########
 @@ -1285,6 +1287,13 @@ public void setName(String name) {
 		customName = name;
 	}
 
+	public void setApplicationType(String type) {
+		if (type == null) {
 
 Review comment:
   Let's use `org.apache.flink.util.Preconditions`:
   
   `this.applicationType = Preconditions.checkNotNull(applicationType, "applicationType must
not be null");`
   
   `setName` should also be refactored in a separate commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message