flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type
Date Wed, 17 Apr 2019 14:27:09 GMT
GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn
application type
URL: https://github.com/apache/flink/pull/7978#discussion_r276268002
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
 ##########
 @@ -201,6 +202,7 @@ public FlinkYarnSessionCli(
 			.build();
 		streaming = new Option(shortPrefix + "st", longPrefix + "streaming", false, "Start Flink
in streaming mode");
 		name = new Option(shortPrefix + "nm", longPrefix + "name", true, "Set a custom name for
the application on YARN");
+		applicationType = new Option(shortPrefix + "at", longPrefix + "applicationType", true,
"Set a custom application type for the application on YARN");
 
 Review comment:
   `yarn_setup.md` should be updated as well I think. Specifically this part:
   
   ```
   {% highlight bash %}
   Usage:
      Optional
        -D <arg>                        Dynamic properties
        -d,--detached                   Start detached
        -jm,--jobManagerMemory <arg>    Memory for JobManager Container with optional
unit (default: MB)
        -nm,--name                      Set a custom name for the application on YARN
        -q,--query                      Display available YARN resources (memory, cores)
        -qu,--queue <arg>               Specify YARN queue.
        -s,--slots <arg>                Number of slots per TaskManager
        -tm,--taskManagerMemory <arg>   Memory per TaskManager Container with optional
unit (default: MB)
        -z,--zookeeperNamespace <arg>   Namespace to create the Zookeeper sub-paths
for HA mode
   {% endhighlight %}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message