flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #8216: [hotfix][tests] Replace deprecated option key with its successor
Date Fri, 19 Apr 2019 05:53:16 GMT
zentol commented on a change in pull request #8216: [hotfix][tests] Replace deprecated option
key with its successor
URL: https://github.com/apache/flink/pull/8216#discussion_r276906921
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
 ##########
 @@ -503,7 +503,7 @@ private void testDetachedPerJobYarnClusterInternal(String job) throws
Exception
 				"-yjm", "768m",
 				// test if the cutoff is passed correctly (only useful when larger than the value
 				// of containerized.heap-cutoff-min (default: 600MB)
-				"-yD", "yarn.heap-cutoff-ratio=0.7",
+				"-yD", "containerized.heap-cutoff-ratio=0.7",
 
 Review comment:
   can we derive the key from an actual `ConfigOption` instead of hard-coding it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message