flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #8205: [FLINK-12238] [TABLE/SQL] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module
Date Fri, 19 Apr 2019 07:33:10 GMT
bowenli86 commented on a change in pull request #8205: [FLINK-12238] [TABLE/SQL] Support database
related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module
URL: https://github.com/apache/flink/pull/8205#discussion_r276920908
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/GenericHiveMetastoreCatalogUtil.java
 ##########
 @@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive;
+
+import org.apache.flink.table.catalog.CatalogDatabase;
+
+import org.apache.hadoop.hive.metastore.api.Database;
+
+import java.util.Map;
+
+
+/**
+ * Utils to convert meta objects between Flink and Hive for GenericHiveMetastoreCatalog.
+ */
+public class GenericHiveMetastoreCatalogUtil {
+
+	private GenericHiveMetastoreCatalogUtil() {
+	}
+
+	// ------ Utils ------
+
+	/**
+	 * Creates a Hive database from CatalogDatabase.
+	 */
+	public static Database createHiveDatabase(String dbName, CatalogDatabase db) {
+		Map<String, String> props = db.getProperties();
+		return new Database(
+			dbName,
+			db.getDescription().get(),
 
 Review comment:
   Good catch, instead doing that, I think a better way is to guarantee the comment in GenericCatalogDatabase
cannot be null. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message