flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
Date Fri, 19 Apr 2019 09:10:52 GMT
zhijiangW edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not
distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#issuecomment-484820243
 
 
   Thanks for the reviews @azagrebin !
   
   If I understand correctly, the total IO related metrics could be divided into two groups.
One group is general and suitable for all `ShuffleService` implementations such as current
`numBytesIn/Out`, `numRecordsIn/Out` which would be still created in current `TaskIOMetrics`.
   
   Another group is special for current `NetworkEnvironment` implementation. We could create
two private classes `NetworkInput/OutputMetrics` inside `NetworkEnvironment`, and the current
metrics of `numBytesInLocal/Remote`, `numBuffersInLocal/Remote`, `input/outputQueueLength`,
`in/outPoolUsage` could be migrated from `TaskIOMetricGroup` into new `NetworkInput/OutputMetrics`,
then we could pass these special metrics into local/remote channels if needed.
   
   Maybe we could not need the new introduced `InputGateWithMetrics` future. We could pass
general `Counter`  (`numBytesIn`, `numBuffersIn`)  from `TaskIOMetrics` in the constructor
of `SingleInputGate` to update these counters properly, not pass specific `TaskIOMetricGroup`
in the constructor. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message