flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #8222: [FLINK-11518] [SQL/TABLE] Add partition related catalog APIs and implement them in GenericInMemoryCatalog
Date Fri, 19 Apr 2019 16:44:18 GMT
bowenli86 commented on a change in pull request #8222: [FLINK-11518] [SQL/TABLE] Add partition
related catalog APIs and implement them in GenericInMemoryCatalog
URL: https://github.com/apache/flink/pull/8222#discussion_r277032972
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
 ##########
 @@ -202,6 +212,8 @@ public void dropTable(ObjectPath tablePath, boolean ignoreIfNotExists)
throws Ta
 
 		if (tableExists(tablePath)) {
 			tables.remove(tablePath);
+
+			partitions.remove(tablePath);
 
 Review comment:
   good catch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message