flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table API] Support UNNEST for MAP types
Date Mon, 22 Apr 2019 13:10:40 GMT
KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table API] Support UNNEST
for MAP types
URL: https://github.com/apache/flink/pull/8179#discussion_r277285495
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
 ##########
 @@ -54,6 +55,15 @@ abstract class ExplodeTableFunction[T] extends TableFunction[T] {
   }
 }
 
+class MapExplodeTableFunc extends TableFunction[Object]{
 
 Review comment:
   I'm not sure making this table function returning object and let framework rely on information
somewhere else to perform right is good choice. This will make the codes fragile. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message