flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dawidwys commented on a change in pull request #8240: [FLINK-12293][docs, datastream]Fix some comment typos in flink-streaming-java.
Date Tue, 23 Apr 2019 05:57:45 GMT
dawidwys commented on a change in pull request #8240: [FLINK-12293][docs, datastream]Fix some
comment typos in flink-streaming-java.
URL: https://github.com/apache/flink/pull/8240#discussion_r277526713
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferBlocker.java
 ##########
 @@ -42,15 +42,15 @@
 	 * Starts a new sequence of buffers and event without reusing the same resources and
 	 * returns the current sequence of buffers for reading.
 	 *
-	 * @return The readable sequence of buffers and events, or 'null', if nothing was added.
+	 * @return The readable sequence of buffers or events, or 'null', if nothing was added.
 	 */
 	BufferOrEventSequence rollOverWithoutReusingResources() throws IOException;
 
 	/**
 	 * Starts a new sequence of buffers and event reusing the same resources and
 	 * returns the current sequence of buffers for reading.
 	 *
-	 * @return The readable sequence of buffers and events, or 'null', if nothing was added.
+	 * @return The readable sequence of buffers or events, or 'null', if nothing was added.
 
 Review comment:
   This doesn't improve the doc. The sequence can contain both buffers **AND** events, not
just one type of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message