flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dawidwys commented on a change in pull request #8240: [FLINK-12293][docs, datastream]Fix some comment typos in flink-streaming-java.
Date Tue, 23 Apr 2019 05:59:54 GMT
dawidwys commented on a change in pull request #8240: [FLINK-12293][docs, datastream]Fix some
comment typos in flink-streaming-java.
URL: https://github.com/apache/flink/pull/8240#discussion_r277527122
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/keys/KeySelectorUtil.java
 ##########
 @@ -67,7 +67,7 @@
 
 	public static <X> ArrayKeySelector<X> getSelectorForArray(int[] positions, TypeInformation<X>
typeInfo) {
 		if (positions == null || positions.length == 0 || positions.length > Tuple.MAX_ARITY)
{
-			throw new IllegalArgumentException("Array keys must have between 1 and " + Tuple.MAX_ARITY
+ " fields.");
+			throw new IllegalArgumentException("The fields of array keys should between 1 and " +
Tuple.MAX_ARITY + ".");
 
 Review comment:
   There is no verb in the sentence. Moreover how does it improve the original message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message