flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces
Date Tue, 23 Apr 2019 13:24:02 GMT
hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments
to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r277672842
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/factories/StreamTableSinkFactory.scala
 ##########
 @@ -20,15 +20,15 @@ package org.apache.flink.table.factories
 
 import java.util
 
-import org.apache.flink.table.sinks.StreamTableSink
+import org.apache.flink.table.sinks.{StreamTableSink, TableSink}
 
 /**
   * A factory to create configured table sink instances in a streaming environment based
on
-  * string-based properties. See also [[TableFactory]] for more information.
+  * string-based properties. See also [[TableSinkFactory]] for more information.
   *
   * @tparam T type of records that the factory consumes
   */
-trait StreamTableSinkFactory[T] extends TableFactory {
+trait StreamTableSinkFactory[T] extends TableSinkFactory[T] {
 
 Review comment:
   I'm not sure. If we put this class into the java-bridge, the scala-bridge needs to depend
on java-bridge, because scala users also need this class.
   Do you think it's right to make scala-bridge depends on java-bridge? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message