flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on issue #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces
Date Tue, 23 Apr 2019 16:52:14 GMT
hequn8128 commented on issue #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#issuecomment-485886064
 
 
   @twalthr @dawidwys Hi, thanks for the review and suggestions. I have updated the PR and
rebased to the master. As the first two commits have been merged, the new commits don't include
them. I also add a fix commit for the compile error problem. 
   
   BTW, @twalthr I have addressed all your comments except for the one about porting StreamTableSinkFactory
into java-bridge. I'm not sure if it is right to let scala-bridge depend on java-bridge. What
do you think of it?
   
   Best, Hequn

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message