flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex
Date Thu, 25 Apr 2019 17:51:37 GMT
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get
max_attempts_history_size value when create ExecutionVertex
URL: https://github.com/apache/flink/pull/8268#discussion_r278663085
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ##########
 @@ -816,6 +817,9 @@ public void attachJobGraph(List<JobVertex> topologiallySorted)
throws JobExcepti
 
 		final ArrayList<ExecutionJobVertex> newExecJobVertices = new ArrayList<>(topologiallySorted.size());
 		final long createTimestamp = System.currentTimeMillis();
+		int maxPriorAttemptsHistoryLength = jobInformation.getJobConfiguration().getInteger(
 
 Review comment:
   hi @tillrohrmann, we need to discuss about the `maxPriorAttemptsHistoryLength` option where
should we get it? 
   
   **First,**, the option is used for `ExecutionJobVertex`, so it should be extracted from
job's configuration. The cluster configuration is like `jobmanager.rpc.address`, `jobmanager.rpc.port`
and so on.
   
   **Second**, the key of the option is `jobmanager.execution.attempts-history-size`, I think
it's better to be changed to `job.execution.attempts-history-size`. because the option is
not used for `jobmanager`
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message