flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] ifndef-SleePy commented on issue #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job
Date Fri, 26 Apr 2019 10:38:24 GMT
ifndef-SleePy commented on issue #8269: [FLINK-12285][test] Harden savepoint relevant test
cases by explicitly canceling test job
URL: https://github.com/apache/flink/pull/8269#issuecomment-487012682
 
 
   Hi @zentol ,
   Currently `MiniCluster` does not clean the running tasks properly, see [FLINK-11630](https://issues.apache.org/jira/browse/FLINK-11630).
As described in this FLINK-12285 JIRA issue, IMO we should explicitly canceling the job before
shutting down cluster. Elegant exit is always a good practice, especially in test case which
there might be other cases run in the same process.
   
   BTW, even though [FLINK-11630](https://issues.apache.org/jira/browse/FLINK-11630) should
solve the memory leaking problem (sadly the PR doesn't work well), it is probably a best-effort
solution. I think we still need this explicitly canceling.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message