flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on issue #8079: [FLINK-12054][Tests] HBaseConnectorITCase fails on Java 9
Date Fri, 26 Apr 2019 11:11:09 GMT
zentol commented on issue #8079: [FLINK-12054][Tests] HBaseConnectorITCase fails on Java 9
URL: https://github.com/apache/flink/pull/8079#issuecomment-487020565
 
 
   @leesf Your solution at the time did not fix the problem as I out-lined in my comment and
you didn't respond to it. I now see that you made another attempt, but it yet again does not
work. This is especially concerning since the very same comment on your first solution _still
applies_ to your second one.
   
   Pull requests are _not_ a public WIP branch, they are to be used for providing, at the
very least, _working_ solutions.
   I closed the PR since I considered it unlikely that you will provide such a solution anytime
soon. Your attempts indicate that you neither verified your solutions, nor truly understand
the code you're changing. 
   
   Please go back to the JIRA, thoroughly analyze the problem, provide&discuss solutions
and verify them, before opening another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message