flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] Aitozi opened a new pull request #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function
Date Fri, 26 Apr 2019 12:11:33 GMT
Aitozi opened a new pull request #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped
function
URL: https://github.com/apache/flink/pull/8280
 
 
   ## What is the purpose of the change
   
   ClosureCleaner is used to clean the implicit `this$x` point to the outer class in the user
defined function to reduce the case of serialization function failed.
   
   But if the function is wrapped by user or the flink framework, it will escape the clean
operation. This pr harden the ClosureCleaner to handle this. And I think it is also a feasible
approach for [[FLINK-12113]](https://issues.apache.org/jira/browse/FLINK-12113)
   
   ## Brief change log
   
   check the field if need to further clean and apply
   
   ## Verifying this change
   
   1. Add the case in the issue to confirm
   2. Add the wrapFunction test case in ClosuerCleanerTest
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message