flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] juangentile commented on a change in pull request #8224: [FLINK-12139][Mesos] Add disk space parameter.
Date Fri, 26 Apr 2019 13:42:07 GMT
juangentile commented on a change in pull request #8224: [FLINK-12139][Mesos] Add disk space
parameter.
URL: https://github.com/apache/flink/pull/8224#discussion_r278953248
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
 ##########
 @@ -220,6 +220,7 @@ public String toString() {
 		taskInfo.addAllResources(allocation.takeScalar("cpus", taskRequest.getCPUs(), roles));
 		taskInfo.addAllResources(allocation.takeScalar("gpus", taskRequest.getGPUs(), roles));
 		taskInfo.addAllResources(allocation.takeScalar("mem", taskRequest.getMemory(), roles));
+		taskInfo.addAllResources(allocation.takeScalar("disk", taskRequest.getDisk(), roles));
 
 Review comment:
   Hello Till,
   
   Sorry for the delay in the response.
   I tested flink on the mesos cluster we have at Criteo and before my change it didn't work
because it was taking the default 0 value for the disk limit.
   In our cluster we enforce the disk usage check but setting this parameter --enforce_container_disk_quota.
   You can find the description of the parameter here: http://mesos.apache.org/documentation/latest/configuration/agent/
   (and here http://mesos.apache.org/documentation/latest/configuration/agent/ - http://mesos.apache.org/documentation/latest/isolators/disk-du/)
   The default installation of mesos has false for enforce_container_disk_quota so the disk
limit is never checked. 
   
   After my change, it works correctly on our mesos cluster (if we set a value different from
the default 0 value using the new parameter).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message