flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] KurtYoung commented on a change in pull request #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…
Date Tue, 30 Apr 2019 08:54:17 GMT
KurtYoung commented on a change in pull request #8312: [FLINK-12366][table] Clean up Catalog
APIs to make them more consiste…
URL: https://github.com/apache/flink/pull/8312#discussion_r279665178
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.java
 ##########
 @@ -174,14 +172,11 @@
 	 * @param partitionSpec partition spec of partition to get
 	 * @return the requested partition
 	 *
-	 * @throws TableNotExistException thrown if the table does not exist in the catalog
-	 * @throws TableNotPartitionedException thrown if the table is not partitioned
-	 * @throws PartitionSpecInvalidException thrown if the given partition spec is invalid,
 	 * @throws PartitionNotExistException thrown if the partition is not partitioned
 	 * @throws CatalogException	in case of any runtime exception
 	 */
 	CatalogPartition getPartition(ObjectPath tablePath, CatalogPartitionSpec partitionSpec)
-		throws TableNotExistException, TableNotPartitionedException, PartitionSpecInvalidException,
PartitionNotExistException, CatalogException;
+		throws PartitionNotExistException, CatalogException;
 
 Review comment:
   I don't quite get the idea why this function will not throw `TableNotExistException`, but
`listPartitions` will. These two methods are both some kind of "get some partition from table".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message