flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW opened a new pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric
Date Tue, 30 Apr 2019 10:28:26 GMT
zhijiangW opened a new pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics
in Task to increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320
 
 
   ## What is the purpose of the change
   
   *Incrementing of `numBytesIn` metric does not depend on specific shuffle service and can
be moved out of network internals into `Task`. `Task` could wrap `InputGate` provided by `ShuffleService`
with `InputGateWithMetrics` which would increment `numBytesIn` metric.*
   
   ## Brief change log
   
     - *Introduce `InputGateWithMetrics` class for implementing `InputGate` interface*
     - *Task wraps `InputGateWithMetrics` with created `InputGate` from `NetworkEnvironment`*
     - *Remove the counter from `SingleInputGate`*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message