flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] azagrebin commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric
Date Tue, 30 Apr 2019 14:09:00 GMT
azagrebin commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce
InputGateWithMetrics in Task to increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r279764419
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferOrEvent.java
 ##########
 @@ -43,26 +46,30 @@
 
 	private int channelIndex;
 
-	BufferOrEvent(Buffer buffer, int channelIndex, boolean moreAvailable) {
+	public BufferOrEvent(Buffer buffer, int channelIndex, boolean moreAvailable, int size) {
 		this.buffer = checkNotNull(buffer);
 		this.event = null;
 		this.channelIndex = channelIndex;
 		this.moreAvailable = moreAvailable;
+		this.size = size;
 
 Review comment:
   `Buffer.getSizeUnsafe()` is already available?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message