flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Rohrmann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7916) Remove NetworkStackThroughputITCase
Date Tue, 09 Apr 2019 12:32:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813337#comment-16813337

Till Rohrmann commented on FLINK-7916:

I think moving it to the {{manual}} package would only slightly improve things and the proper
solution would be to have a {{benchmark}} module.

> Remove NetworkStackThroughputITCase
> -----------------------------------
>                 Key: FLINK-7916
>                 URL: https://issues.apache.org/jira/browse/FLINK-7916
>             Project: Flink
>          Issue Type: Task
>          Components: Runtime / Network, Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Ji Liu
>            Priority: Major
> Flink's code base contains the {{NetworkStackThroughputITCase}} which is not really a
test. Moreover it is marked as {{Ignored}}. I propose to remove this test because it is more
of a benchmark. We could think about creating a benchmark project where we move these kind
of "tests".
> In general I think we should remove ignored tests if they won't be fixed immediately.
The danger is far too high that we forget about them and then we only keep the maintenance
burden of it. This is especially true for the above mentioned test case.

This message was sent by Atlassian JIRA

View raw message