flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rong Rong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11936) Remove AuxiliaryConverter pull-in from calcite and fix auxiliary converter issue.
Date Thu, 11 Apr 2019 15:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815489#comment-16815489
] 

Rong Rong commented on FLINK-11936:
-----------------------------------

After some investigation. seems like our code is far deviated from the AuxiliaryConverter
and it was not kept in sync with the Calcite side. Any idea what would be the best approach
here?

I am keen toward making AuxiliaryConverter implementations loaded dynamically. Currently default
impl is loaded into SqlToRelConverter directly without any possibility to allow any 3rd party
override. what do you think [~twalthr] ?

Another approach is to restructure the current TUMBLE/HO/SESSION window properties to align
with AuxiliaryConverter logic. This would require some Calcite side fixes as well since there's
still a "TODO" tag on the SESSION_END branch.

> Remove AuxiliaryConverter pull-in from calcite and fix auxiliary converter issue.
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-11936
>                 URL: https://issues.apache.org/jira/browse/FLINK-11936
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / API
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> AuxiliaryConverter was pulled inĀ FLINK-6409. SinceĀ CALCITE-1761 has been fixed, we
should sync back with the calcite version.
> After a quick glance, I think it is not so simple to just delete the class so I opened
a follow up Jira on this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message