From issues-return-229247-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Tue Apr 30 10:11:43 2019 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 70E5418407 for ; Tue, 30 Apr 2019 10:11:43 +0000 (UTC) Received: (qmail 95285 invoked by uid 500); 30 Apr 2019 10:11:42 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 95255 invoked by uid 500); 30 Apr 2019 10:11:42 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 95246 invoked by uid 99); 30 Apr 2019 10:11:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2019 10:11:42 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] [flink] StephanEwen commented on a change in pull request #8290: [FLINK-12070] [network] Implement new bounded blocking subpartitions Message-ID: <155661910261.27341.10326311503832193870.gitbox@gitbox.apache.org> Date: Tue, 30 Apr 2019 10:11:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit StephanEwen commented on a change in pull request #8290: [FLINK-12070] [network] Implement new bounded blocking subpartitions URL: https://github.com/apache/flink/pull/8290#discussion_r279691968 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ########## @@ -565,7 +565,13 @@ public void requestPartitions() throws IOException, InterruptedException { return Optional.of(new BufferOrEvent(buffer, currentChannel.getChannelIndex(), moreAvailable)); } else { - final AbstractEvent event = EventSerializer.fromBuffer(buffer, getClass().getClassLoader()); + final AbstractEvent event; + try { + event = EventSerializer.fromBuffer(buffer, getClass().getClassLoader()); + } + finally { + buffer.recycleBuffer(); Review comment: can look into this ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services