flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink
Date Thu, 02 May 2019 12:05:49 GMT
zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop
from flink
URL: https://github.com/apache/flink/pull/8225#discussion_r280388777
 
 

 ##########
 File path: flink-dist/src/main/assemblies/hadoop.xml
 ##########
 @@ -28,13 +28,14 @@ under the License.
 	<includeBaseDirectory>true</includeBaseDirectory>
 	<baseDirectory>flink-${project.version}</baseDirectory>
 
-	<files>
-		<!-- copy the Hadoop uber jar -->
-		<file>
-			<source>../flink-shaded-hadoop/flink-shaded-hadoop2-uber/target/flink-shaded-hadoop2-uber-${hadoop.version}-${project.version}.jar</source>
+	<dependencySets>
+		<dependencySet>
 			<outputDirectory>lib/</outputDirectory>
-			<destName>flink-shaded-hadoop2-uber-${project.version}-${hadoop.version}.jar</destName>
-			<fileMode>0644</fileMode>
-		</file>
-	</files>
+			<useTransitiveDependencies>true</useTransitiveDependencies>
+			<scope>provided</scope>
 
 Review comment:
   we could add `<outputFileNameMapping>${artifact.artifactId}-${artifact.baseVersion}.${artifact.extension}</outputFileNameMapping>
   `, so that (for SNAPSHOT builds) the jar is always called `flink-shaded-hadoop2-uber-2.4.1-1.9-SNAPSHOT.jar`,
and not `flink-shaded-hadoop2-uber-2.4.1-1.9-629462874621478328407-23.jar`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message