flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure
Date Sun, 05 May 2019 05:53:33 GMT
zhijiangW commented on a change in pull request #8242: [FLINK-6227][network] Introduce the
DataConsumptionException for downstream task failure
URL: https://github.com/apache/flink/pull/8242#discussion_r281005469
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -162,10 +164,13 @@ void assignExclusiveSegments(List<MemorySegment> segments) {
 	public void requestSubpartition(int subpartitionIndex) throws IOException, InterruptedException
{
 		if (partitionRequestClient == null) {
 			// Create a client and request the partition
-			partitionRequestClient = connectionManager
-				.createPartitionRequestClient(connectionId);
+			try {
+				partitionRequestClient = connectionManager.createPartitionRequestClient(connectionId);
+			} catch (RemoteTransportException ex) {
 
 Review comment:
   It should check `IOException` here and only wrap for `RemoteTransportException` instance.
   For the case of `LocalTransportException` it should not need to restart producer side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message