flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support
Date Sun, 05 May 2019 06:28:44 GMT
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add
base python framework and Add Scan, Projection, and Filter operator support
URL: https://github.com/apache/flink/pull/8267#discussion_r281006384
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/api/python/PythonGatewayServer.java
 ##########
 @@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.python;
+
+import py4j.GatewayServer;
+
+import java.io.DataOutputStream;
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.net.InetAddress;
+
+/**
+ * The Py4j Gateway Server provides RPC service for user's python process.
+ */
+public class PythonGatewayServer {
 
 Review comment:
   I think It's better to move this class into `flin-core` module, due to `flink-python` only
conatains python scripts, and Eliminate the interdependence of flink-table and flink-python
(future). And create a root package for python in `flink-core`, such as : `org.apache.flink.api.python`.
 What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message