flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] shaoxuan-wang commented on issue #7446: Added Model serving - implementation of the Flip -23.
Date Mon, 06 May 2019 02:29:10 GMT
shaoxuan-wang commented on issue #7446: Added Model serving - implementation of the Flip -23.
URL: https://github.com/apache/flink/pull/7446#issuecomment-489486186
 
 
   Hi @blublinsky, thanks for the contribution. As we talked offline, I have observed there
are at least three issues of this PR against the "contribution checklist".  (You can find
the "contribution checklist" when you create pull request or [Flink website](https://flink.apache.org/contribute-code.html).
Please carefully follow those instructions). I hope those issues can be fixed before moving
forward on this PR. 
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).

     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request",
where FLINK-XXXX should be replaced by the actual issue number. Skip component if you are
unsure about which is the best component. I noticed that you have created [FLINK-12186](https://issues.apache.org/jira/browse/FLINK-12186)
on April 14th after we talked offline. So this PR should be named as something like "[FLINK-12186]
[ml] Flink model serving"
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
The Travis CI build of this PR was failed and it also needs a rebase due to the conflicts
with the master files.
   
   Since there is not much inline review comment yet, I highly suggest that you close this
PR and resubmit a new PR once fixed the CI build errors on your personal github.
   
   I have other comments about the interface of model serving and some suggestions of the
detailed implementations. I will send those comments to the dev ML with a broader visibility
to collect feedback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message