flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on a change in pull request #8347: [FLINK-12326][python] Add basic test framework for python api
Date Tue, 07 May 2019 02:12:53 GMT
sunjincheng121 commented on a change in pull request #8347: [FLINK-12326][python] Add basic
test framework for python api
URL: https://github.com/apache/flink/pull/8347#discussion_r281428840
 
 

 ##########
 File path: flink-python/pyflink/testing/test_case_utils.py
 ##########
 @@ -0,0 +1,64 @@
+################################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+#################################################################################
+
+import os
+import sys
+import unittest
+
+from pyflink.find_flink_home import _find_flink_home
+from pyflink.table import TableEnvironment, TableConfig
+
+if sys.version_info[0] >= 3:
+    xrange = range
+
+
+class PyFlinkTestCase(unittest.TestCase):
+    """
+    Base class for unit tests.
+    """
+
+    def setUp(self):
+        os.environ["FLINK_TESTING"] = "1"
+
+        _find_flink_home()
+        print("using %s as FLINK_HOME..." % os.environ["FLINK_HOME"])
 
 Review comment:
   I think we should use` LOGGER = logging.getLogger().` instead of print´╝î what to you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message