flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] xuefuz commented on a change in pull request #8339: [FLINK-12240][hive] Support view related operations in GenericHiveMetastoreCatalog
Date Tue, 07 May 2019 04:53:23 GMT
xuefuz commented on a change in pull request #8339: [FLINK-12240][hive] Support view related
operations in GenericHiveMetastoreCatalog
URL: https://github.com/apache/flink/pull/8339#discussion_r281460262
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/GenericHiveMetastoreCatalogUtil.java
 ##########
 @@ -148,14 +161,24 @@ public static CatalogBaseTable createCatalogTable(Table hiveTable)
{
 		// Partition keys
 		List<String> partitionKeys = new ArrayList<>();
 
-		if (hiveTable.getPartitionKeys() != null && hiveTable.getPartitionKeys().isEmpty())
{
+		if (hiveTable.getPartitionKeys().isEmpty()) {
 			partitionKeys = hiveTable.getPartitionKeys().stream()
 
 Review comment:
   if hive table partition keys are empty, we we need to iterate thru it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message