flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog
Date Wed, 08 May 2019 06:17:42 GMT
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in
HiveCatalog
URL: https://github.com/apache/flink/pull/8353#issuecomment-490362402
 
 
   Thanks @xuefuz . The reason I use util methods is because as the logic complexity grows,
the size of two catalog classes can be quite big. I'm fine to remove util methods and keep
shared logic in HiveCatalogBase and special logic of each catalog in its own class now, and
we can reevaluate whenever necessary.
   
   Looking at each commit would probably be easier. To summarize the changes:
   
   - moved shared logic to HiveCatalogBase
   - added a few interfaces in HiveCatalogBase for subclasses to implement
   - updated test util and a few tests to cater to above changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message