flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog
Date Wed, 08 May 2019 21:19:07 GMT
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in
HiveCatalog
URL: https://github.com/apache/flink/pull/8353#issuecomment-490654662
 
 
   > Thanks for refactoring the code. It looks much cleaner now.
   > 
   > However, I still noticed there are still a lot of commonality between the two implementations
of createHiveTable() and createCatalogTable(). Maybe we can share more code between them and
reduce the code duplication.
   
   @xuefuz they currently look similar mainly because HiveCatalog's implementation is only
preliminary at the moment as mentioned in comment. As we enrich HiveCatalog, I expect they
will diverge a lot. It would be better to try to unify their common parts in the end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message