flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist
Date Thu, 09 May 2019 07:07:57 GMT
zentol commented on a change in pull request #8377: [FLINK-12455][python] Move the packaging
of pyflink to flink-dist
URL: https://github.com/apache/flink/pull/8377#discussion_r282361738
 
 

 ##########
 File path: flink-dist/pom.xml
 ##########
 @@ -588,6 +588,31 @@ under the License.
 				</executions>
 			</plugin>
 
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-antrun-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>package</id>
+						<phase>package</phase>
+						<goals>
+							<goal>run</goal>
+						</goals>
+						<configuration>
+							<target>
+								<delete>
+									<fileset dir="${project.basedir}/../flink-python/pyflink" includes="**/*.pyc"/>
 
 Review comment:
   I mean that this logic should continue to be encapsulated in flink-python. Flink-dist should
only do 1 thing: pick assembled artifacts and copy them somewhere.
   
   What problem are we solving here? What's so bad about having a separate pom in flink-python?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message