flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric
Date Fri, 10 May 2019 09:33:44 GMT
zhijiangW commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce
InputGateWithMetrics in Task to increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r282808860
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/InputGateWithMetrics.java
 ##########
 @@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.taskmanager;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.runtime.event.TaskEvent;
+import org.apache.flink.runtime.io.network.partition.consumer.BufferOrEvent;
+import org.apache.flink.runtime.io.network.partition.consumer.InputGate;
+import org.apache.flink.runtime.io.network.partition.consumer.InputGateListener;
+import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
+
+import java.io.IOException;
+import java.util.Optional;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * The InputGateWithMetrics is wrapped in task with {@link InputGate} provided by
+ * shuffle service. It is mainly used for increasing general input metrics from
+ * {@link TaskIOMetricGroup}.
+ */
+public class InputGateWithMetrics implements InputGate, InputGateListener {
+
+	private final InputGate inputGate;
+
+	private final Counter numBytesInCounter;
+
+	/** Registered listener to forward buffer notifications to. */
+	private volatile InputGateListener inputGateListener;
+
+	InputGateWithMetrics(InputGate inputGate, Counter numBytesInCounter) {
+		this.inputGate = checkNotNull(inputGate);
+		this.numBytesInCounter = checkNotNull(numBytesInCounter);
+	}
+
+	@Override
+	public int getNumberOfInputChannels() {
+		return inputGate.getNumberOfInputChannels();
+	}
+
+	@Override
+	public String getOwningTaskName() {
+		return inputGate.getOwningTaskName();
+	}
+
+	@Override
+	public boolean isFinished() {
+		return inputGate.isFinished();
+	}
+
+	@Override
+	public void requestPartitions() throws IOException, InterruptedException {
+		inputGate.requestPartitions();
+	}
+
+	@Override
+	public Optional<BufferOrEvent> getNextBufferOrEvent() throws IOException, InterruptedException
{
+		Optional<BufferOrEvent> bufferOrEvent = inputGate.getNextBufferOrEvent();
+		if (bufferOrEvent.isPresent()) {
+			numBytesInCounter.inc(bufferOrEvent.get().getSize());
+		}
+
+		return bufferOrEvent;
+	}
+
+	@Override
+	public Optional<BufferOrEvent> pollNextBufferOrEvent() throws IOException, InterruptedException
{
+		return inputGate.pollNextBufferOrEvent();
+	}
+
+	@Override
+	public void sendTaskEvent(TaskEvent event) throws IOException {
+		inputGate.sendTaskEvent(event);
+	}
+
+	@Override
+	public void registerListener(InputGateListener inputGateListener) {
+		if (this.inputGateListener == null) {
+			this.inputGateListener = inputGateListener;
+		} else {
+			throw new IllegalStateException("Multiple listeners");
+		}
+
+		inputGate.registerListener(this);
+	}
+
+	@Override
+	public int getPageSize() {
+		return inputGate.getPageSize();
+	}
+
+	@Override
+	public void close() throws Exception {
 
 Review comment:
   In current implementation, the close call in task in from `SingleInputGate`, and the `InputGateWithMetrics`
created in task is only used in `RuntimeEnvironment`, we do not change the previous arrays
in task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message