flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] Myasuka commented on issue #8328: [FLINK-12380] Add thread name in the log4j.properties
Date Sat, 11 May 2019 05:56:38 GMT
Myasuka commented on issue #8328: [FLINK-12380] Add thread name in the log4j.properties
URL: https://github.com/apache/flink/pull/8328#issuecomment-491482568
 
 
   @StephanEwen As you are the founder of Flink and the most-contributed coder, I believe
and respect your choice.
   However, your reply actually did not convince me. I struggled to hesitate whether to voice
my thoughts. Since Apache Flink is an open source software, I believe every word counts.
   
   1. >  We kept it stable for a while now, which seems to have been generally appreciated
by users.
   
   I am not sure about other users but we might have the largest Flink cluster in the world
but add thread name explicitly in `log4j.properties`.
   
   2. Actually [logback.xml](https://github.com/apache/flink/blob/a7cf24383be9f310fb5ccc5a032721421fa45791/flink-dist/src/main/flink-bin/conf/logback.xml#L24)
already contains the thread name.
   
   Last but not least, if your choice is based on "Even though `log4j` and `logback` have
different log pattern, but the log system for Flink works well so far, we should not touch
this without any strong demand." I think this would be acceptable for me, and hope for no
more demands come out to add sub-task index information in logs.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message